Re: [libvirt] [PATCHv2 10/21] fix fallout in src/xen
On 06.03.2013 16:37, Peter Krempa wrote:
---
src/xen/xen_driver.c | 8 ++++++--
src/xen/xen_driver.h | 1 +
src/xen/xend_internal.c | 8 ++++----
src/xen/xm_internal.c | 2 +-
4 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index d896893..fd20b73 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -401,6 +401,9 @@ xenUnifiedOpen(virConnectPtr conn, virConnectAuthPtr auth, unsigned
int flags)
goto fail;
}
+ if (!(priv->xmlconf = virDomainXMLConfNew(NULL, NULL)))
+ goto fail;
+
Okay, this is what I meant when I was talking about dropping the wrapper
function. However, again: virDomainXMLConfNew(NULL, NULL) does no good
(nor bad) for now. But you mean this as preparation for future work,
right? Anyway, I am sure you got my point, so I am stopping to report
this in my review.
#if WITH_XEN_INOTIFY
if (xenHavePrivilege()) {
VIR_DEBUG("Trying Xen inotify sub-driver");