-----Original Message----- From: Eric Blake [mailto:eblake@redhat.com] Sent: Wednesday, October 09, 2013 9:51 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]docs: exit if failed to generate html
On 10/09/2013 05:27 AM, Chen Hanxiao wrote:
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
If xhtml1 dtd not install, some html will not be generated. If we 'make install', it will succeed and message "missing XHTML1 DTD" will be hide inside a large amount of logs. So exit when this occurs.
NACK; this is already being worked on in a different thread, with a different approach (if DTDs aren't present, my goal is to just use unvalidated xml): https://www.redhat.com/archives/libvir-list/2013-October/msg00254.html
There are too many distros that don't yet provide xhtml1 dtds easily to make it a hard requirement for validation, although my work will eventually get us to the point that xmllint is a hard requirement for doc generation when doing a git checkout.
Your patch could fix my issue. Thanks for your information.
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org