On 12/20/2013 03:16 AM, Daniel P. Berrange wrote:
What distro were you on when you hit this failure? I'm a little bit reluctant to bump the minimum requirement without knowing a bit more about how common 3.0 is in practice. Adding more details in your commit log about why you needed it (not just what you changed) makes it easier to review.
We discussed this on IRC - the earliest version that I tested was on Fedora 19 which have GNUTLS 3.1.11 which passes. On OpenSuse they have 3.0.28 which failed. Technically we could bisect every darn release version between these two to find out where the fix came in, but frankly it is easier to just assume 3.1.0 until the unlikely event that someone else complains :-)
Yep - updating the commit message to mention OpenSuse, and comparing the failing 3.0.28 to the working Fedora 3.1.11, is sufficient justification for bumping to blanket 3.1. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org