Re: [Libvir] [PATCH] virDomainMigrate version 4 (for discussion only!)

> + if (resource) { > + virXendError (conn, VIR_ERR_NO_SUPPORT, > + "xenDaemonDomainMigrate: Xen does not support resource limits during migration"); > + return -1; > + } Hum, strange, the classical Xen bandwidth during live migration of http picture uses a 100Mbps capped transfer, so that ought to work at least at some point in the past, weird.

> + if (strstr (uri, "//")) { /* Full URI. */ > + xmlURIPtr uriptr = xmlParseURI (uri); > + if (!uriptr) { > + virXendError (conn, VIR_ERR_INVALID_ARG, > + "xenDaemonDomainMigrate: invalid URI"); > + return -1; > + } > + if (uriptr->scheme && STRCASENEQ (uriptr->scheme, "tcp")) { > + virXendError (conn, VIR_ERR_INVALID_ARG, > + "xenDaemonDomainMigrate: only tcp:// migrations are supported by Xen"); > + xmlFreeURI (uriptr); > + return -1; > + } > + if (!uriptr->server) { > + virXendError (conn, VIR_ERR_INVALID_ARG, > + "xenDaemonDomainMigrate: a hostname must be specified in the URI"); > + xmlFreeURI (uriptr); > + return -1; > + } > + hostname = strdup (uriptr->server); > + if (!hostname) { > + virXendError (conn, VIR_ERR_NO_MEMORY, "strdup"); > + xmlFreeURI (uriptr); > + return -1; > + } > + if (uriptr->port) > + snprintf (port, sizeof port, "%d", uriptr->port); > + xmlFreeURI (uriptr); > + } > + else if ((p = strrchr (uri, ':')) != NULL) { /* "hostname:port" */

> + else { /* "hostname" (or IP address) */

Hum, we say it's an uri, but we interpret is differently if it's not absolute this could lead to confusion. But I'm not sure being a purist here would help that much from an user POV.