Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL
On Tue, Sep 04, 2018 at 02:10:56PM +0200, Andrea Bolognani wrote:
On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote:
> > > Pushed as a build fix for platforms without JSON parser installed
> >
> > Which platforms? All machines in our CI environments should have
> > yajl installed.
>
> It wasn't CI - it was my own FreeBSD machine without yajl
I see someone hasn't been using lcitool :P
Note the CI machines are just a representative set of build targets, they
are not providing exhaustive coverage. If we have a --without-yajl option,
then we should be able to sucessfully build without yajl, even if the OS
is capable of supporting yajl.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|