On 12/16/2010 09:50 AM, Daniel P. Berrange wrote:
The QEMU driver file is far too large. Move all the hostdev
helper code out into a separate file. No functional change.
* src/qemu/qemu_hostdev.c, src/qemu/qemu_hostdev.h,
src/Makefile.am: Add hostdev helper file
* src/qemu/qemu_driver.c: Delete hostdev code
---
src/Makefile.am | 1 +
src/qemu/qemu_driver.c | 266 +-------------------------------------------
src/qemu/qemu_hostdev.c | 289 +++++++++++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_hostdev.h | 45 ++++++++
4 files changed, 337 insertions(+), 264 deletions(-)
create mode 100644 src/qemu/qemu_hostdev.c
create mode 100644 src/qemu/qemu_hostdev.h
ACK, with one nit.
+void qemuReattachPciDevice(pciDevice *dev, struct qemud_driver
*driver);
+void qemuDomainReAttachHostdevDevices(struct qemud_driver *driver,
+ virDomainHostdevDefPtr *hostdevs,
+ int nhostdevs);
+void qemuDomainReAttachHostDevices(struct qemud_driver *driver,
Should you use this as an opportunity to s/ReAttach/Reattach/g, for
consistency among these three functions?
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org