Re: [libvirt] [Qemu-devel] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

On 10/10/2012 08:20 AM, Corey Bryant wrote: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > This patch also prevents removal of an fd from an fd set during > initialization. This allows the fd to remain in the fd set after > probing of the image file. You're mixing code motion and semantic change in one patch (keyword "also" in your commit message; should the semantic change be moved to a separate patch (possibly squashed into 1/3)?

> > Signed-off-by: Corey Bryant <coreyb(a)linux.vnet.ibm.com&gt; > --- > > - if (has_fdset_id) { > - QLIST_FOREACH(mon_fdset, &mon_fdsets, next) { > - if (mon_fdset->id == fdset_id) { > - break; > - } > - } > - } Since you maintain mon_fdsets in sorted id order, should you optimize this loop to abort the QLIST_FOREACH early if fdset_id is less than mon_fdset->id? [I only noticed this because of code motion, so it is a pre-existing condition and therefore a separate patch, or another thing to squash into 1/3]