Re: [libvirt] [PATCH 1/2] Introduce virDomainYesNo enum type

On Mon, Jul 14, 2014 at 04:47:16PM +0200, Ján Tomko wrote: > @@ -10901,9 +10884,9 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, > "for useserial")); > goto cleanup; > } > - def->os.bios.useserial = VIR_DOMAIN_BIOS_USESERIAL_YES; > + def->os.bios.useserial = VIR_DOMAIN_YES_NO_ENABLED; > } else { > - def->os.bios.useserial = VIR_DOMAIN_BIOS_USESERIAL_NO; > + def->os.bios.useserial = VIR_DOMAIN_YES_NO_DISABLED; > } > VIR_FREE(tmp); > } > > @@ -16943,10 +16926,10 @@ virDomainGraphicsDefFormat(virBufferPtr buf, > virDomainGraphicsSpiceMouseModeTypeToString(def->data.spice.mousemode)); > if (def->data.spice.copypaste) > virBufferAsprintf(buf, "<clipboard copypaste='%s'/>\n", > - virDomainGraphicsSpiceClipboardCopypasteTypeToString(def->data.spice.copypaste)); > + virDomainYesNoTypeToString(def->data.spice.copypaste)); > if (def->data.spice.filetransfer) > virBufferAsprintf(buf, "<filetransfer enable='%s'/>\n", > - virDomainGraphicsSpiceAgentFileTransferTypeToString(def->data.spice.filetransfer)); > + virDomainYesNoTypeToString(def->data.spice.filetransfer)); > } I'm not really a fan of this cleanup, as IMHO the result is less clear & harder to follow than the original code.