Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

> +++ w/src/uml/uml_driver.c > @@ -1599,7 +1599,9 @@ static char *umlDomainGetXMLDesc(virDomainPtr dom, > virDomainObjPtr vm; > char *ret = NULL; > > - virCheckFlags(0, NULL); > + virCheckFlags(VIR_DOMAIN_XML_SECURE | > + VIR_DOMAIN_XML_INACTIVE | > + VIR_DOMAIN_XML_UPDATE_CPU, NULL); > > umlDriverLock(driver); > vm = virDomainFindByUUID(&driver->domains, dom->uuid); I'm not sure if it's a good idea to add the flags check for this set of flags at the driver level. Maybe it should be moved one level down into virDomainDefFormat. This avoids touching all drivers should we ever add a new VIR_DOMAIN_XML_* flag.