Re: [libvirt] [PATCH] domain_conf: move iothread check for address type back to qemu_command
On Wed, Mar 08, 2017 at 05:50:11PM +0100, Pavel Hrdina wrote:
This partially reverts commit c96bd78e4e.
That commit also moved the check that ensures the controller type
is virtio-scsi. However, it seems qemuDomainSetSCSIControllerModel
which can also possibly set the default model to virtio-scsi
(if QEMU does not support LSI) now gets called after
virDomainControllerDefValidate.
Jan
If an API virDomainAttachDevice(Flags) is used the device address
is assigned after the validation and the address type may not be set.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430275
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/conf/domain_conf.c | 18 ++++--------------
src/qemu/qemu_command.c | 22 ++++++++++++++++++++++
2 files changed, 26 insertions(+), 14 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)