Re: [libvirt PATCH] qemu: Do not return NULL when qemuMigrationSrcBegin succeeds

On 5/23/22 16:46, Jiri Denemark wrote:

My recent commit v8.3.0-201-gc500955e95 tried to fix a regression which would cause the function to return success even if virCloseCallbacksSet failed. But due to a strange code flow in the function introduced an opposite regression. The function would return NULL on success when called without VIR_MIGRATE_CHANGE_PROTECTION flag.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/qemu/qemu_migration.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal