Re: [libvirt] [PATCH 2/3] tools: Set CFLAGS for wireshark properly
On Thu, Nov 16, 2017 at 02:49:28PM +0100, Michal Privoznik wrote:
We want to set CFLAGS not CPPFLAGS.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
tools/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 7513a73ac..a844dcbbc 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -427,7 +427,7 @@ EXTRA_DIST += \
if WITH_WIRESHARK_DISSECTOR
ws_plugin_LTLIBRARIES = wireshark/src/libvirt.la
-wireshark_src_libvirt_la_CPPFLAGS = \
CPPFLAGS are flags for preprocessor IIUC but judging from the variable's
content == other CFLAGS, I think this is OK while also being a "no change".
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>