2010/3/9 Sharadha Prabhakar (3P) <sharadha.prabhakar@citrix.com>:
Patch 1 is sent as attachment. It contains changes suggested in this mail. Some comments inline. Sharadha
Okay, I applied and pushed the patches. Thanks! I tried to setup a Citric XenServer in order to test the driver, but I failed. XenServer supports x86_64 only and I have currently no x86_64 server to spare for this, so I tried installing it as ESX guest, but failed. The installer complains about a non-x86_64 system. At that point I gave up testing for now. The code as is looks good now. There are some minor issues left, like variable declarations in the middle of a block. The last major issue the username handling. If no username is passed in the URI, you're using NULL. Matthias