Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

On 05/21/2010 09:28 AM, Cole Robinson wrote: >> Any interest in doing this with netlink instead? (I've got this "thing" >> against parsing text files to get information if it can be retrieved via >> a nice clean API). If so, I think I can whip up the equivalent code with >> libnl calls, but probably not until later in the afternoon. >> >> If I'm the only one who feels uneasy about parsing stuff out of /proc, >> then I'm fine with that too. >> > > My feeling is it depends on what else libnl buys us. A library > dependency for a single safety check doesn't seem worth it. If we use > the lib, we definitely don't want it to be optional, as debugging > network issues in the future shouldn't require asking 'is libvirt > compiled against libnl'. Stefan just posted a patch series that would also add a dependency on libnl for vepa; as long as we are using the library, we might as well use it for more than one thing.