4 Feb
2022
4 Feb
'22
10:56 a.m.
On 2/3/22 18:56, Vasily Ulyanov wrote:
Hi Michal,
On 03/02/2022 18:09, Michal Prívozník wrote:
Apart from patch 2/3 this looks good. So here's what we are going to do. I've uploaded fixup commits onto my gitlab:
https://gitlab.com/MichalPrivoznik/libvirt/-/commits/virpidfile/
Please take a look and if you agree I will squash those fixup commits and merge.
Thank you for the detailed explanation in 2/3. Makes sense. Probably I need to dive a bit deeper into the code the next time. And yeah, I missed that redundant include initially and noticed it only after sending the patches. I agree on squashing the fixups and merging.
Perfect, fixed and merged. Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal