Re: [libvirt] [PATCH sandbox v5 06/20] Image: Add download function

On Wed, 2015-09-09 at 12:55 +0100, Daniel P. Berrange wrote: > On Wed, Sep 09, 2015 at 01:50:11PM +0200, Cedric Bosdonnat wrote: > > This wording really sounds docker-specific. The registry word only fits > > docker terminology, would surely not apply to virt-builder or appc case. > > Something like "images storage" would may be more generic. The problem > > is that "repository" has a special meaning in the docker terminology. > > Yeah, I was thinking we might need some way to let source subclasses > add custom arguments. eg so we'd have --docker-registry. > > The appc spec doesn't have a concept of a central registry in the > same way as docker. Instead the image name encodes the domain > name, eg example.com/someapp, and there's a protocol to use > this to identify the server, and then resolve the download URL > > > ACK, but may need some thinking on the "Registry" word. > > I'm inclined to merge this, and then fix it afterwards to be more > generic Sure... but then we surely don't want to get a release out with the temporary parameter.