Re: [libvirt] PATCH: Write pidfile earlier in startup
On Tue, May 20, 2008 at 12:02:03PM -0400, Daniel Veillard wrote:
On Fri, May 16, 2008 at 05:39:46PM +0100, Daniel P. Berrange wrote:
> On Fri, May 16, 2008 at 05:05:08PM +0100, Daniel P. Berrange wrote:
> There were actually some more changes needed. It needs to write the PID file
> even if not running with --daemon mode to be truely safe, because some
> init software won't run it in daemon mode at all. So this updated patch will
> always write a PID file if run as root. It also fixes a few flaws in the
> cleanup process to ensure it only unlinks the pidfile on failure if it owned
> the pidfile, and removes a pointless warning when running non-root.
Yes this is a serious problem, patch looks fine, +1
Thanks, I've commited this.
Dan
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|