Re: [libvirt] [PATCH v2 03/14] qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM
On 03/07/2017 05:01 PM, John Ferlan wrote:
On 02/27/2017 08:19 AM, Michal Privoznik wrote:
> Introduce a qemu capability for -device nvdimm.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/qemu/qemu_capabilities.c | 9 +++++++++
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 10 insertions(+)
>
So this doesn't require tests/qemu*/caps_2.*.xml changes to add a:
<flag name='nvdimm'/> ?
No. It doesn't. Basically, we need the version check because we are
waiting for Dan's patch to get in:
http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg00636.html
There will be no way for us to detect that. I mean, other than version
check. It sucks still, I agree on that. Therefore, even though some
older qemus do support nvdims, libvirt claims no support because they
are lacking the Dan's fix. It was discussed somewhere on the list, but I
don't remember where from the top of my head - perhaps in review of v1?
Michal