Re: [Libvir] [PATCH] Add Xen Scheduler APIs to xenDaemonDriver
On Mon, 24 Mar 2008 05:27:04 -0400 Daniel Veillard wrote:
On Mon, Mar 24, 2008 at 02:12:25PM +0900, Saori Fukuta wrote:
> How about the second one ? We can make some improvements for virsh
> schedinfo command with the patch, so I want the patch to be committed
> if it is OK.
I had forgotten about it, sorry.
It looks okay, though i have to clean a few problems raised by
'make syntax-check' (please try this in future patches). I commited it to CVS.
Thank you for applying it. I will try "syntax-check" next time.
However, i don't see why it is needed, basically when running
with Xen
as root, the hypervisor access should be used, not xend, so this seems to
indicate that you have problem using the hypervisor calls and that's probably
something to worry about. But it's fine having a more complete xend driver
surrport.
Yes, the hypervisor access should be used for root user.
But if a domain is inactive, we cannot see/set the scheduler parameters
with visrh command even though xm command can do it since we cannot
access to the hypervisor.
And also, we cannot allow to see the scheduler parameters for user who
connect with read-only for the same reason.
For such case, I thought we needed the patch to access with Xend driver.
thanks a lot,
Saori.