Re: [libvirt] [PATCH] nwfilter: plub memory leak with firewall

On Tue, Jul 22, 2014 at 10:19:54PM -0600, Eric Blake wrote: > Introduced in commit 70571ccc. Caught by valgrind: > > ==9816== 170 (32 direct, 138 indirect) bytes in 1 blocks are > definitely lost in loss record 646 of 821 > ==9816== at 0x4A081D4: calloc (in > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > ==9816== by 0x50836FB: virAlloc (viralloc.c:144) > ==9816== by 0x50AEC2B: virFirewallNew (virfirewall.c:204) > ==9816== by 0x1E2308ED: ebiptablesDriverProbeStateMatch > (nwfilter_ebiptables_driver.c:3715) > ==9816== by 0x1E2309AD: ebiptablesDriverInit > (nwfilter_ebiptables_driver.c:3742) > > * src/nwfilter/nwfilter_ebiptables_driver.c > (ebiptablesDriverProbeStateMatch): Properly clean up. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/nwfilter/nwfilter_ebiptables_driver.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > ACK,