Re: [libvirt] [PATCH sandbox v5 00/20] Docker image support

This is an update of Eren's v4 patch series to provide Docker image support. In this v5 I have incorporated fixes for all of the feedback I gave Eren against the v4, so I think this series is ready for merging now. One thing I still want to look at separately is how applicable this design is to other container formats, in particular the 'appc' specification https://github.com/appc/spec/blob/master/spec/discovery.md Before we make a release containing the docker impl, I want to be confident we've not done anything silly which will cause us compat problems if we want to extend to cover appc later. Daniel P Berrange (1): Add virt-sandbox-image Daniel P. Berrange (1): Rename 'name' to 'template' to disambiguate Eren Yagdiran (18): Fix docker authentication handling Image: Add Hooking Mechanism Image: virt-sandbox-image default dir constants Image: Add download function Image: Refactor create function Image: Add delete function Image: Add get_command function to Source Image: Add run args Image: Add check_connect function Image: Add get_disk function to Source Image: Add run function Image: Add network support Image: man file for virt-sandbox-image Add config for environment variables Add environment parameter to virt-sandbox init-common: Exporting custom environment variables Image: Add custom environment support Image: Add Volume Support .gitignore | 1 + bin/Makefile.am | 8 +- bin/virt-sandbox-image | 8 + bin/virt-sandbox-image.pod | 169 +++++++++++ bin/virt-sandbox.c | 14 + configure.ac | 3 + libvirt-sandbox.spec.in | 3 + libvirt-sandbox/Makefile.am | 2 +- libvirt-sandbox/image/Makefile.am | 10 + libvirt-sandbox/image/__init__.py | 0 libvirt-sandbox/image/cli.py | 293 ++++++++++++++++++ libvirt-sandbox/image/sources/DockerSource.py | 416 ++++++++++++++++++++++++++ libvirt-sandbox/image/sources/Makefile.am | 9 + libvirt-sandbox/image/sources/Source.py | 117 ++++++++ libvirt-sandbox/image/sources/__init__.py | 0 libvirt-sandbox/libvirt-sandbox-config.c | 171 ++++++++++- libvirt-sandbox/libvirt-sandbox-config.h | 13 + libvirt-sandbox/libvirt-sandbox-init-common.c | 18 ++ libvirt-sandbox/libvirt-sandbox.sym | 9 + libvirt-sandbox/tests/test-config.c | 10 + po/POTFILES.in | 1 + 21 files changed, 1272 insertions(+), 3 deletions(-) create mode 100644 bin/virt-sandbox-image create mode 100644 bin/virt-sandbox-image.pod create mode 100644 libvirt-sandbox/image/Makefile.am create mode 100644 libvirt-sandbox/image/__init__.py create mode 100755 libvirt-sandbox/image/cli.py create mode 100644 libvirt-sandbox/image/sources/DockerSource.py create mode 100644 libvirt-sandbox/image/sources/Makefile.am create mode 100644 libvirt-sandbox/image/sources/Source.py create mode 100644 libvirt-sandbox/image/sources/__init__.py -- 2.4.3