On Friday 27 May 2011 16:01:32 Matthias Bolte wrote:
Thanks, pushed then.
There are other usages of getline in the OpenVZ driver, but they should all be safe because they don't distinguish between 0 and -1, except openvzGetProcessInfo.
Jean-Baptiste could you test virsh dominfo of a running OpenVZ domain? I expect it to currently fail and will post a patch for it.
Matthias
virsh dominfo on a running domain doesn't fail here :
virsh # dominfo 100 ID : 100 Nom : 100 UUID : 0a0cf7cb-efb4-4065-ac2d-e63ad51e72cf Type de SE : exe État : en cours d'exécution CPU : 1 Temps CPU : 2,3s Mémoire Max : 262144 kB Mémoire utilisée : 262144 kB Persistent: yes Autostart: disable
I tried it on a stopped domain and it doesn't fail either. Jean-Baptiste -- Jean-Baptiste ROUAULT Ingénieur R&D - Diateam : Architectes de l'information Phone : +33 (0)9 53 16 02 70 Fax : +33 (0)2 98 050 051