Re: [libvirt RFC 0/2] qemu: handle 'raw' format options 'size' and 'offset'
On Thu, Jan 16, 2020 at 05:17:43PM +0000, Richard W.M. Jones wrote:
On Thu, Jan 16, 2020 at 05:56:38PM +0100, Peter Krempa wrote:
> See patch 2 please.
>
> Peter Krempa (2):
> tests: storage: Add test data for json specified raw image with
> offset/size
> qemu: Handle 'offset' and 'size' parameters of 'raw'
driver
>
> src/conf/domain_conf.c | 19 +++++++++++++++++++
> src/qemu/qemu_block.c | 10 ++++------
> src/util/virstoragefile.c | 21 +++++++++++++++++----
> src/util/virstoragefile.h | 4 ++++
> tests/virstoragetest.c | 15 +++++++++++++++
> 5 files changed, 59 insertions(+), 10 deletions(-)
Can confirm that this fixes the issue in the virt-v2v test suite.
Actually I'm sorry to say it didn't fix it. I'm not sure what exactly
happened there. I might have missed the error message or I ran the
test suite in the wrong way, or perhaps the error is intermittent.
Anyway I have to withdraw the "Tested-by" until I can take a closer
look at this.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html