Re: [libvirt] [PATCH] Fix syntax error on Python 3.7

On 27.6.2018 13:47, Pavel Hrdina wrote: > On Wed, Jun 27, 2018 at 01:03:03PM +0200, Miro Hrončok wrote: >>  From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= <miro(a)hroncok.cz&gt; >> Date: Wed, 27 Jun 2018 13:00:28 +0200 >> Subject: [PATCH] Fix syntax error on Python 3.7 >> >> async is a keyword now. >> >> `asyncio import ensure_future` works on Python 3.4 to 3.7 >> >> `from asyncio import async as ensure_future` is not needed. >> --- >>   libvirtaio.py | 5 +---- >>   1 file changed, 1 insertion(+), 4 deletions(-) > > Thanks for the patch, but as noted in this review [1] using only > 'ensure_future' is not good enough. > > Pavel > > [1] <https://www.redhat.com/archives/libvir-list/2018-June/msg01700.html> In that case you need to get async dynamically...