On 02/27/2014 07:43 AM, Daniel P. Berrange wrote:
+/* Domain memory dump's format */
/* */ comments don't make it through to the html doc pages. Here, you want something like: /** * virDomainCoreDumpFormat: * Values for specifying different formats of domain core dumps. */
+typedef enum { + VIR_MEMORY_DUMP_COMPRESS_ZLIB = 1, /* dump guest memory in + kdump-compressed format, with + zlib-compressed */ + VIR_MEMORY_DUMP_COMPRESS_LZO = 2, /* dump guest memory in + kdump-compressed format, with + lzo-compressed */ + VIR_MEMORY_DUMP_COMPRESS_SNAPPY = 3, /* dump guest memory in + kdump-compressed format, with + snappy-compressed */ +} virMemoryDumpFormat;
Missing a *_LAST enum value, under proper #ifdef.
s/virMemoryDumpFormat/virDomainCoreDumpFormat/
No need to assign values to each entry here since this is a plain enum, not bitflags.
Also s/MEMORY_COMPRESS/DOMAIN_CORE_FORMAT/ for every member
And add VIR_MEMORY_DUMP_FORMAT_RAW for the non-compressed format, which probably ought to be the default (ie first).
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org