On 4/12/21 4:04 PM, Luke Yue wrote:
The g_path_is_absolute() considers more situations
than just a simply "path[0] == '/'".
Related issue:
https://gitlab.com/libvirt/libvirt/-/issues/12
Signed-off-by: Luke Yue <lukedyue(a)gmail.com>
---
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 93fac200cc..3311eaff3d 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -3153,7 +3153,7 @@ virFileOpenTty(int *ttyprimary G_GNUC_UNUSED,
int
virFileAbsPath(const char *path, char **abspath)
{
- if (path[0] == '/') {
+ if (g_path_is_absolute(path)) {
*abspath = g_strdup(path);
} else {
g_autofree char *buf = g_get_current_dir();
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
and congratulations on your first libvirt contribution!
Although, there are more places like this. Quick git grep -n
"\[0\].*'/'" shows something. Can you post patch for them too? Maybe
not every occurrence needs the same treatment, I know.
Michal