Re: [libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver
Thanks Eric. The push looks good. There is a small (known) issue with
the text monitor interface and a one-liner will fix that. I can send
that out once I have verified against upstream qemu.
On 06/14/2011 10:56 PM, Eric Blake wrote:
On 06/14/2011 08:36 AM, Adam Litke wrote:
> The generator can handle DomainBlockPullAll and DomainBlockPullAbort.
> DomainBlockPull and DomainBlockPullInfo must be written by hand.
>
> * src/remote/remote_protocol.x: provide defines for the new entry points
> * src/remote/remote_driver.c daemon/remote.c: implement the client and
> server side
> * src/remote_protocol-structs: structure definitions for protocol verification
>
> Signed-off-by: Adam Litke <agl(a)us.ibm.com>
> ---
> daemon/remote.c | 71 ++++++++++++++++++++++++++++++++++++++++++
> src/remote/remote_driver.c | 68 ++++++++++++++++++++++++++++++++++++++++
> src/remote/remote_protocol.x | 40 +++++++++++++++++++++++-
> src/remote_protocol-structs | 28 ++++++++++++++++
> 4 files changed, 206 insertions(+), 1 deletions(-)
ACK for addressing the v3 comments, but there are merge conflicts due to
all of today's patches. Double-check my work, but I think I got it all
right.
Pushed.
--
Adam Litke
IBM Linux Technology Center