Re: [libvirt] [PATCH v3 12/14] migration: reuse parameters check in toURI2 and toURI3
On Fri, Sep 18, 2015 at 18:05:50 +0300, Nikolay Shirokovskiy wrote:
It is *not* a pure refactoring patch as it introduces offline check
for older
versions. Looks like it must be done that way and no one will be broken too.
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com>
---
src/libvirt-domain.c | 75 ++++++++++----------------------------------------
1 files changed, 15 insertions(+), 60 deletions(-)
I think you could squash this patch into the previous one which does
similar thing in *ToURI.
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index eec45bd..fc61830 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -4253,7 +4253,6 @@ virDomainMigrateToURI(virDomainPtr domain,
/* First checkout the source */
virCheckDomainReturn(domain, -1);
virCheckReadOnlyGoto(domain->conn->flags, error);
-
virCheckNonNullArgGoto(duri, error);
if (virDomainMigrateUnmanagedCheckCompat(domain, flags) < 0)
And this hunk definitely doesn't belong to this patch... one more reason
to squash patch 12 and 11 :-)
Jirka