Re: [RFC PATCH v1 08/15] node_device_udev: Take lock if `driver->privateData` is modified

On 4/12/24 8:36 AM, Marc Hartmayer wrote: > Since @driver->privateData is modified take the lock. >

> * signal if that event never comes */ > - scheduleMdevctlUpdate(priv, (event_type == G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT)); > + VIR_WITH_OBJECT_LOCK_GUARD(priv) { > + scheduleMdevctlUpdate(priv, (event_type == G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT)); > + } > } > > I don't see any cases where we would not want to take the lock (e.g. because it has already been taken), so maybe it would be better simply to lock the object within the scheduleMdevctlUpdate() function rather than requiring each caller to lock it?

Reviewed-by: Jonathon Jongsma <jjongsma(a)redhat.com&gt;