Re: [libvirt] [PATCH] domain_conf: fix graphics parsing

On 04/11/2016 07:37 AM, Pavel Hrdina wrote: > Commit dc98a5bc refactored the code a lot and forget about checking if > listen attribute is specified. This ensures that listen attribute and > first listen element are compared only if both exist. > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > ---

> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c > index 0735677..dddc775 100644 > --- a/tests/qemuxml2xmltest.c > +++ b/tests/qemuxml2xmltest.c > @@ -430,6 +430,7 @@ mymain(void) > DO_TEST("graphics-vnc-websocket"); > DO_TEST("graphics-vnc-sasl"); > DO_TEST("graphics-vnc-tls"); > + DO_TEST("graphics-vnc-no-listen-attr"); > DO_TEST("graphics-sdl"); > DO_TEST("graphics-sdl-fullscreen"); > DO_TEST("graphics-spice"); > Adding a qemu test here is overkill IMO, this is just checking a function of the generic XML parser so can be more easily tested with genericxml2xml. In fact I already have patches testing the compat from the other direction: http://www.redhat.com/archives/libvir-list/2016-April/msg00395.html We could extend that test case with another <graphics> block that tests the listen compat in the other direction.