Re: [libvirt] [PATCH v5 4/5] storage: Support "chap" authentication for iscsi pool

On 07/23/2013 10:56 AM, Daniel P. Berrange wrote: <...snip...> >> +++ b/src/storage/storage_backend_iscsi.c >> @@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal, >> >> if (!conn) { >> virReportError(VIR_ERR_INTERNAL_ERROR, "%s", >> - _("iscsi 'chap' authentication requires connection")); >> + _("iscsi 'chap' authentication not supported " >> + "for autostarted pools")); >> return -1; >> } > > I noticed that the nwfilter already unconditionally calls virConnectOpen("qemu://system"); so we're already in fact suffering from the problem with > autostart having a qemu dependency. > > Given this, I'd support a patch which simply did > > conn = virConnectOpen(privilege ? "qemu:///system" : "qemu:///session"); > > in storageDriverAutostart, provided that we ignore any errors from > virConnectOpen, and fallback to use NULL for the connection in that > case. > > Obviously this is something we'll still need to fix properly in a > future release, but at least it'll make autostart of storage pools > with auth work in the common case in the short term for this release. > > Regards, > Daniel > So resurrect the following: https://www.redhat.com/archives/libvir-list/2013-July/msg00962.html