On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote:
On Fri, Mar 21, 2008 at 10:17:35AM -0700, Dave Leskovec wrote:
Daniel Veillard wrote:
I will look now at cleaning up the parsing code as explained in my review, that I can do easilly,
Excellent. Thanks!
No problem, BTW I'm having a bit of troubles with lxcLoadConfig() it loads fine an example xml based on the original from your mail, but then it does:
virUUIDFormat(containerDef->uuid, uuidstr); if (!virFileMatchesNameSuffix(file, uuidstr, ".xml")) {
which fails, what's the semantic ? The uuid field seems uninitialized, and then the match doesn't work. Are you generating the uuid based on the filename ? Maybe a random one would be fine, but why that check ?
Another small issue is that I have the clone flags defined in <linux/sched.h> but not in <sched.h> so I had to add that include to get the module to compile, lxcCheckContainerSupport() check then passes on my Fedora-8 2.6.24 kernel.
I filed https://bugzilla.redhat.com/show_bug.cgi?id=438542 to request the flags are added to sched.h too, but we should just #define them in the driver as we do for Xen hypervisor constants. This avoids a hard dependancy between the kernel used for compile, vs running. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|