14 Apr
2014
14 Apr
'14
9:24 p.m.
On 04/08/2014 09:37 AM, Daniel P. Berrange wrote:
The virNWFilterHashTable struct contains a virHashTable and then a 'char **names' field which keeps a copy of all the hash keys. Presumably this was intended to record the ordering of the hash keys. No code ever uses this and the ordering is mangled whenever a variable is removed from the hash, because the last element in the list is copied into the middle of the list when shrinking the arra.
s/arra/array/
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> ---
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org