Re: [libvirt] [PATCH 2/4] test_driver: extract image loading code into a separate function
On Wed, May 29, 2019 at 02:22:57PM +0200, Ilias Stamatis wrote:
Extracting the code logic for opening and parsing a test image from
testDomainRestoreFlags into a separate function, allows us to reuse this
code in other functions such as testDomainSaveImageGetXMLDesc.
Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com>
---
src/test/test_driver.c | 115 ++++++++++++++++++++++++++---------------
1 file changed, 72 insertions(+), 43 deletions(-)
This diff from format-patch seems okay, but when you apply the patch and use
git show (even with -M), the diff is very hard to read. It would be improved if
you extracted it right above testDomainRestoreFlags which is the only function
making use of this helper.
Code-wise I don't see anything wrong.
Erik