Re: [libvirt] [PATCH v3 21/48] secret: introduce virtsecretd daemon
On Tue, Jul 30, 2019 at 04:01:15PM +0200, Andrea Bolognani wrote:
On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote:
[...]
> +virtsecretd.service: secret/virtsecretd.service.in $(top_builddir)/config.status
> + $(AM_V_GEN)sed $(VIRTSECRETD_UNIT_VARS) < $< > $@-t && mv $@-t
$@
> +
> +virtsecret%.socket: remote/libvirt%.socket.in $(top_builddir)/config.status
> + $(AM_V_GEN)sed $(VIRTSECRETD_UNIT_VARS) < $< > $@-t && mv $@-t
$@
> +
> +secret/virtsecretd.conf: remote/libvirtd.conf.in
> + $(AM_V_GEN)sed \
> + -e '/[@]CUT_ENABLE_IP[@]/,/[@]END[@]/d' \
> + -e 's/[@]DAEMON_NAME[@]/virtsecretd/' \
> + < $^ > $@
Oh, you didn't replace $^ with $< here!
I did the previous patch, forgetting i replicated the problem in
every following patch.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|