Re: [libvirt] [PATCH] libxl: Allow libxl to set NIC devid
Jiri Denemark wrote:
On Thu, Jun 20, 2013 at 11:47:18 -0600, Jim Fehlig wrote:
> libxl contains logic to determine an appropriate devid for new devices
> that do not specify one in their configuration. For all device types
> except NICs, the libxl driver allows libxl to determine devid. Do the
> same for NICs.
> ---
> src/libxl/libxl_conf.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 812d380..1be66da 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -609,8 +609,6 @@ libxlMakeNicList(virDomainDefPtr def, libxl_domain_config
*d_config)
> }
>
> for (i = 0; i < nnics; i++) {
> - x_nics[i].devid = i;
> -
> if (libxlMakeNic(l_nics[i], &x_nics[i]))
> goto error;
> }
>
ACK
Thanks, pushed.
Regards,
Jim