Re: [libvirt] [PATCH] remote: Fill remote parameters in remoteDomainListAllSnapshots()

On 04.07.2012 11:01, Peter Krempa wrote:

This patch fills the domain argument that is sent to the remote side. This caused a client segfault as the argument was NULL. --- src/remote/remote_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 6f53264..eac50e6 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -4888,6 +4888,7 @@ remoteDomainListAllSnapshots(virDomainPtr dom,

remoteDriverLock(priv);

+ make_nonnull_domain(&args.dom, dom); args.need_results = !!snapshots; args.flags = flags;

ACK trivial but still serious. Michal