On 9/18/24 17:26, Laine Stump wrote:
These patches are in response to a bug report filed a few years ago where I said "I can look at it next week" and then promptly forgot about it :-/
https://bugzilla.redhat.com/1949432
I was reminded of it when a bunch of old bugs were migrated from bugzilla.redhat.com to issues.redhat.com and Yalan Zhang added the comment that the bug was still reproducible on libvirt 10.4.0.
https://issues.redhat.com/browse/RHEL-7036
This got it back onto my todo list (where it should have been the entire time!) and I've finally gotten to it. Two similar-but-differen failures had been reported (one when using a network of "direct" (macvtap) devices, and one when using an openvswitch bridge, and it turned out that two different (but related) fixes were needed - the direct problem is fixed *mostly* in patch 1, with the other patches fixing the ovs problem (and the remainder of the direct problem).
Laine Stump (4): qemu: prevent unnecessarily failing live interface update util: don't return early from virNetDevTapReattachBridge() if "force" is true qemu: replace open-coded remove/attach bridge with virNetDevTapReattachBridge() qemu: rework needBridgeChange/needReconnect decisions in qemuDomainChangeNet()
src/conf/domain_conf.c | 2 +- src/qemu/qemu_hotplug.c | 263 +++++++++++++++++++++++++--------------- src/util/virnetdevtap.c | 8 +- src/util/virnetdevtap.h | 3 +- 4 files changed, 172 insertions(+), 104 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal`