Re: [libvirt] Release candidate 2 of 1.0.3 is available

2 Mar 2013

On Sat, Mar 02, 2013 at 03:30:38PM +0100, Christophe Fergeau wrote:
...

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 0e56596..1ecc8fa 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1301,8 +1301,8 @@ void qemuDomainObjCheckTaint(virQEMUDriverPtr driver,
if (cfg->privileged &&
         (!cfg->clearEmulatorCapabilities ||
-         cfg->user == 0 ||
-         cfg->group == 0))
+         cfg->user == (uid_t)-1 ||
+         cfg->group == (gid_t)-1))
This hunk actually seems unneeded, maybe even harmful as this 0 check only
triggers on system libvirtd, while this patch sets user/group to be -1 in
the session (unpriviledged) libvirtd case.

Christophe

    