On Wed, Feb 17, 2016 at 21:25:41 -0500, John Ferlan wrote:
Add new function to manage adding the '-smbios' options to the command line removing that task from the mainline qemuBuildCommandLine
Also while I was looking at it, move the uuid processing closer to usage.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_command.c | 147 +++++++++++++++++++++++++++--------------------- 1 file changed, 83 insertions(+), 64 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 27952e5..0e3b516 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4457,6 +4457,86 @@ static char *qemuBuildSmbiosBaseBoardStr(virSysinfoBaseBoardDefPtr def)
[...]
+ + virCommandAddArgList(cmd, "-smbios", smbioscmd, NULL); + VIR_FREE(smbioscmd); + } + } + + return 0; + + error:
No need for the error label in this function.
+ return -1; +} + + static char * qemuBuildClockArgStr(virDomainClockDefPtr def) {
ACK with the label removed