On Tue, Dec 12, 2006 at 08:34:08AM -0500, Daniel Veillard wrote:
On Mon, Dec 11, 2006 at 08:58:45PM +0000, Daniel P. Berrange wrote:
+ if (xmlStrEqual(graphics_type, BAD_CAST "sdl")) { + virBufferAdd(buf, "(type sdl)", 10); + // TODO: + // Need to understand sdl options + // + //virBufferAdd(buf, "(display localhost:10.0)", 24); + //virBufferAdd(buf, "(xauthority /root/.Xauthority)", 30);
Let's avoid C++ style comments if possible.
Opps, that was copy & pasted from original code. I've fixed this & the original to use C scomments.
+ /* New style PVFB config - 3.0.4 merge */ + if (xendConfigVersion >= 3 && !hvm) { + obj = xmlXPathEval(BAD_CAST "/domain/devices/graphics", ctxt); + if ((obj != NULL) && (obj->type == XPATH_NODESET) && + (obj->nodesetval != NULL) && (obj->nodesetval->nodeNr >= 0)) { + for (i = 0; i < obj->nodesetval->nodeNr; i++) { + res = virDomainParseXMLGraphicsDescNew(obj->nodesetval->nodeTab[i], &buf);
So if using HVM, we still call virDomainParseXMLGraphicsDescOld, even if using the new interface, maybe the renaming New/Old is not perfect then, because that's not the only factor in selecting one or the other. But it's rather a stylistic comment :-)
Renamed to virDomainParseXMLGraphicsDescVFB and virDomainParseXMLGraphicsDescImage to reflect where they appear in the SEXPR. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|