Re: [libvirt] [PATCH 2/7] iscsi: Check for validity of pool source hostname

On Sun, Apr 19, 2015 at 20:49:07 -0400, John Ferlan wrote: > Ensure that the pool that's being started has a source pool hostname > that can be resolved before trying to start an iSCSI session. > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > src/storage/storage_backend_iscsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c > index 197d333..958c347 100644 > --- a/src/storage/storage_backend_iscsi.c > +++ b/src/storage/storage_backend_iscsi.c > @@ -385,6 +385,13 @@ virStorageBackendISCSIStartPool(virConnectPtr conn, > return -1; > } > > + if (!virIsValidHostname(pool->def->source.hosts[0].name)) { > + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > + _("cannot resolve hostname '%s' on this host"), > + pool->def->source.hosts[0].name); > + return -1; This overwrites the error from virIsValidHostname()