2010/8/2 Daniel Veillard <veillard@redhat.com>:
On Mon, Aug 02, 2010 at 08:10:57PM +0200, Matthias Bolte wrote:
2010/8/2 Daniel Veillard <veillard@redhat.com>:
it seems to me that this change the behaviour of vServer access, so I'm tempted to get this pushed in 0.8.3, rather than wait for the next version to change things. On one hand this breaks the freeze, but this is focused to one specific kind of hypervisor whose support is being added, so I think this is fine to push before the release if you agree,
Daniel
This patch is the reason that I asked you to delay 0.8.3 a bit. Prior to this patch you could connect to a whole vCenter, this resulted in multiple problems as you already saw in the initial vCenter patch. The bunch of "TODOs without an error message". Also Dan pointed out that being able to connect to a whole vCenter is probably out of libvirt's scope.
With this patch the vCenter connection is restricted to a single ESX server. This solves all the "TODOs without an error message". Including the patch into 0.8.3 makes sure that we have the opportunity to relax the restrictions on a vCenter connection later on (if that turns out to be to be feasible), instead of having to apply restrictions in later releases.
The other 4 patches just came along with this one, and I'd like to include all 5 into 0.8.3.
Okay, fine by me, please push, I will make the release, probably tomorrow,
thanks !
Daniel
Thanks, pushed all 5 patches now. Matthias