On Fri, Apr 05, 2019 at 05:54:41PM +0200, Andrea Bolognani wrote:
On Fri, 2019-04-05 at 16:12 +0100, Daniel P. Berrangé wrote: [...]
+ } else if (what == "devs") { + form.setAttribute("action", "https://google.com/search"); + newq.setAttribute("name", "q"); + newq.value = "site:redhat.com inurl:/archives/libvir-list " + q.value; + } else if (what == "users") { + form.setAttribute("action", "https://google.com/search"); + newq.setAttribute("name", "q"); + newq.value = "site:redhat.com inurl:/archives/libvirt-users " + q.value; + }
It seems like
site:redhat.com/archives/libvir-list site:redhat.com/archives/libvirt-users
would work just as well, and at least to my eyes that looks less alien that what you have up there. Your version works too, though, so feel free to change it or leave it alone based on your personal preference.
[...]
+++ b/docs/mobile.css @@ -15,6 +15,7 @@ margin: 0px; background: white; padding: 0px; + height: 2em; } #search form { padding: 5px; @@ -91,4 +92,10 @@ float: none; margin-bottom: 2em; } + #advancedsearch { + margin-top: 4em; + border: 0px; + background: white; + color: black; + } }
Oh boy, what is even going on with indentation in this file? It's one most insane indentation styles I've ever seen. Your additions are entirely consistent with existing code, though, so I'll just look the other way and try to forget what I've just witnessed.
It isn't that insane - it is just using tabs so it appears wierd when your tab indent < 8. We should just extend our no-tabs checking to cover the CSS too. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|