Re: [libvirt] [python PATCH v7] Add virDomainCheckpoint APIs
On 4/3/19 4:49 AM, Daniel P. Berrangé wrote:
On Wed, Mar 27, 2019 at 05:09:27AM -0500, Eric Blake wrote:
> Copies heavily from existing virDomainSnapshot handling, regarding
> what special cases the generator has to be taught and what overrides
> need to be written.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
>
> Python counterparts to my incremental backup patches. An earlier
> version was already reviewed by Dan; the main diff here is the
> addition of virDomainSnapshotCreateXML2 handling.
Now that 5.6.0 will have the virDomainCheckpoint API but not
virDomainSnapshotCreateXML2, I've reduced this patch down to the
portions still relevant and pushed. When we later get around to
integrating snapshots and checkpoints, we'll tweak the python bindings
again at that time to cover any additional APIs.
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)