Re: [libvirt PATCH] spec: Merge -bash-completion and -admin into -client

On Thu, 2021-04-15 at 11:10 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 15, 2021 at 11:36:19AM +0200, Michal Privoznik wrote: > > The -client package needs then to obsolete those packages which you're > > removing. Loo around at "Obsoletes:" tag we have around. > > Also needs a Provides tag to satisy any deps other packages have on it Makes sense, will do. > > However, I'm not sure that virt-admin should go to client package. For > > instance, I can install -client to control remote daemon but virt-admin > > works only locally (because we want it to). Therefore, if anything, it > > should go in the same package as libvirtd. But taking split daemons into > > account - any of them should drag in virt-admin. Some of the things that currently live in the -client package are also local-only: virt-host-validate, virt-pki-validate and libvirt-guests. I agree that the distinction is not entirely clear-cut, but virt-admin fits slightly better in -client than in -daemon IMHO.