Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

On 07/09/2011 02:44 AM, Matthias Bolte wrote: > Yes, that approach is nicer and also the logic it a bit simpler. Here's a v2. > > -- Matthias Bolte http://photron.blogspot.com > > Subject: [PATCH] tests: Fix compressed test output padding logic > > The current logic tries to count from 1 to 40 and ignores paddings > of 0 and 1 to 40. This doesn't work for counter + 1 mod 40 == 0 > like here for counter value 159 > > TEST: virsh-all >       ........................................ 40 >       ........................................ 80 >       ........................................ 120 >       ....................................... 159 OK > PASS: virsh-all > > Also seq isn't portable. Therefore, calculate the correct padding > length directly and use printf to output it at once. > --- >  tests/test-lib.sh |    9 ++------- >  1 files changed, 2 insertions(+), 7 deletions(-) ACK.