On 05/16/2017 06:27 PM, Laine Stump wrote:
On 05/10/2017 04:58 AM, Vasiliy Tolstov wrote:
Hi! Sometimes ago i'm write patch for setting link state of network interface for ethernet type (tap). Now i'm try libvirt 3.3.0 and see, that tap interfaces is up but in xml i'm try to specify <link state='down'> also i'm try <source><link state='down'></source> Nothing changed. Laine says, that link state is only for internal representation, and to modify link state on host side i need to specify <source><link state='down'></source>.
I remember we talked about implementing that, but did we actually do it? I may implied/suggested that I would, and then dropped the ball (it's happened before :-/)
Yep :-( I looked through the thread and see that I had said I was writing a patch to do that, but apparently I never finished it and it's sitting somewhere on one of the dozens of "mystery branches" in my sandbox.
Definitely I did push the patch that disconnects the up/down status of the host side of the tap from the up/down status of the emulated NIC.
For history please check email thread "qemu: remove unnecessary setting of tap device online state"
So does this bug or it my mistake? Thanks!
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list