Re: [libvirt] [v0.9.12-maint 7/9] Include process start time when doing polkit checks

On Wed, Sep 18, 2013 at 09:14:23PM -0600, Eric Blake wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Since PIDs can be reused, polkit prefers to be given > a (PID,start time) pair. If given a PID on its own, > it will attempt to lookup the start time in /proc/pid/stat, > though this is subject to races. > > It is safer if the client app resolves the PID start > time itself, because as long as the app has the client > socket open, the client PID won't be reused. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > (cherry picked from commit 979e9c56a7aadf2dcfbddd1abfbad594b78b4468) > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; >

> + > + > +size_t virStringListLength(char **strings) > +{ > + size_t i = 0; > + > + while (strings && strings[i]) > + i++; > + > + return i; > +} This looks a bit as if it could go into a separate commit since it adds a new utility function, but that's minor. Otherwise ACK to the whole series.