Re: [libvirt] [PATCH] Make locking more debuggable from logs
On Tue, Jul 23, 2013 at 08:34:35AM +0200, Martin Kletzander wrote:
On 07/22/2013 06:31 PM, Eric Blake wrote:
> On 07/22/2013 07:58 AM, Daniel P. Berrange wrote:
>> I'm really inclined to say that anyone wanting todo lock debugging
>> should just use systemtap / dtrace todo it, since it is better in
>> every way.
>
> I tend to agree on that point, with one caveat - we need to have good
> documentation on how to do systemtap debugging of libvirt, in order to
> make it easy to point someone to the steps they need to follow to
> benefit from it. Our existing web pages on hacking are a bit sparse on
> this front.
>
OK, thanks for your input. My point was to enable this for people who
don't want to (or can't) use systemtap for various reasons, but I guess
nobody can be *that* lazy to do 'package_app install_command systemtap'
and then cleanup afterwards.
I like your idea of explaining systemtap debugging with libvirt on
wiki/documentation. I'll try to combine it with additional systemtap
examples and put it all together somehow. But I need you to check my
grammar, since it tends to be a longer text.
Could add an example systemtap script demonstrating how todo it in
the examples/systemtap directory too. Let me know if you need any
assistance with systemtap. There's a little bit of a learning curve,
but usually not as bad as people fear it will be. IME, it is well
worth any effect spent learning how to use it, you'll make back the
time many times over once you know it.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|